Pr Validate

# Executable spec for the /pr-validate skill — PR submission-readiness (driving-adapter).
# /pr-validate checks that a PR branch is clean, focused, and ready to submit: isolation,
# upstream alignment, scope containment, and quality gates. Hexagon: driving-adapter; consumes
# validation; produces result.json; customer-of validation. (soc-qk4b)

Feature: PR-validate checks a PR branch is submission-ready
  As the pre-submission PR check
  I want a branch verified for isolation, upstream alignment, scope, and quality
  So that only clean, focused PRs reach the upstream

  Scenario: a PR branch is validated across the readiness dimensions
    When /pr-validate runs on a branch
    Then it checks isolation, upstream alignment, scope containment, and quality gates
    And it produces a PR validation report

  Scenario: scope creep is flagged
    When the branch contains changes outside the contribution's scope
    Then /pr-validate flags the scope-containment failure as not-ready

  Scenario: a failing quality gate blocks readiness
    When a quality gate fails on the branch
    Then /pr-validate reports the branch as not submission-ready


#!/bin/bash
# Validate pr-validate skill
set -euo pipefail

SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
SKILL_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"

ERRORS=0
CHECKS=0

check_pattern() {
    local desc="$1"
    local file="$2"
    local pattern="$3"

    CHECKS=$((CHECKS + 1))
    if grep -qiE "$pattern" "$file" 2>/dev/null; then
        echo "✓ $desc"
    else
        echo "✗ $desc (pattern '$pattern' not found in $file)"
        ERRORS=$((ERRORS + 1))
    fi
}

echo "=== PR Validate Skill Validation ==="
echo ""

check_pattern "SKILL.md checks upstream alignment" "$SKILL_DIR/SKILL.md" "[Uu]pstream[[:space:]]+[Aa]lignment"
check_pattern "SKILL.md checks isolation" "$SKILL_DIR/SKILL.md" "[Ii]solation[[:space:]]+[Cc]heck"
check_pattern "SKILL.md checks scope creep" "$SKILL_DIR/SKILL.md" "[Ss]cope[[:space:]]+[Cc]heck|scope creep"
check_pattern "SKILL.md has Examples section" "$SKILL_DIR/SKILL.md" "^## Examples"
check_pattern "SKILL.md has Troubleshooting section" "$SKILL_DIR/SKILL.md" "^## Troubleshooting"

echo ""
echo "=== Results ==="
echo "Checks: $CHECKS"
echo "Errors: $ERRORS"

if [ $ERRORS -gt 0 ]; then
    echo ""
    echo "FAIL: pr-validate skill validation failed"
    exit 1
else
    echo ""
    echo "PASS: pr-validate skill validation passed"
    exit 0
fi


---
name: pr-validate
description: Validate PR scope and quality.
practices:
- continuous-integration
- code-complete
- pragmatic-programmer
hexagonal_role: driving-adapter
consumes:
- validation
produces:
- result.json
context_rel:
- kind: customer-of
  with: validation
skill_api_version: 1
context:
  window: fork
  intent:
    mode: task
  sections:
    exclude:
    - HISTORY
  intel_scope: topic
license: MIT
compatibility: Requires git, gh CLI
metadata:
  author: AI Platform Team
  version: 1.0.0
  tier: contribute
  internal: false
allowed-tools: Read, Bash, Grep, Glob
output_contract: 'stdout: PR validation report'
---
# PR Validate Skill

PR-specific validation that ensures changes are clean, focused, and ready.

## Overview

Validates a PR branch for submission readiness by checking isolation, upstream
alignment, scope containment, and quality gates.

**Input**: Branch name (default: current branch)

**When to Use**:
- Before running `$pr-prep`
- After `$pr-implement` completes
- When suspicious of scope creep

---

## Workflow

```
1.  Branch Discovery     -> Identify branch and upstream
2.  Upstream Alignment   -> FIRST: Check rebase status (BLOCKING)
3.  CONTRIBUTING.md      -> Verify compliance (BLOCKING)
4.  Isolation Check      -> Single type, thematic files
5.  Scope Check          -> Verify changes match intended scope
6.  Quality Gate         -> Tests, linting (non-blocking)
7.  Report Generation    -> Summary with pass/fail
```

---

## Phase 2: Upstream Alignment (BLOCKING - CHECK FIRST)

```bash
# Fetc