
Upstream Pr
- 1 installs
- Updated May 12, 2026
- connor93/em-web-client
Process for submitting and reviewing upstream pull requests in the EM web client project.
About
Guidelines for opening upstream PRs and getting them reviewed and merged. Contributors follow it when submitting changes.
- PR submission template and requirements
- Review and feedback process
Upstream Pr by the numbers
- 1 all-time installs (skills.sh)
- Ranked #524 of 733 Git & Pull Requests skills by installs in the Skillselion catalog
- Data as of Jul 8, 2026 (Skillselion catalog sync)
npx skills add https://github.com/connor93/em-web-client --skill upstream-prAdd your badge
Show developers this skill is listed on Skillselion. Paste this into your README.
| Installs | 1 |
|---|---|
| Last updated | May 12, 2026 |
| Repository | connor93/em-web-client ↗ |
What it does
Process for submitting and reviewing upstream pull requests in the EM web client project.
Files
Upstream PR
Create a standalone feature branch off upstream/master for submitting a PR to sorokya/eoweb.
Arguments
- feature: Feature name for the branch (e.g.,
guild-dialog,auto-battle) - files: Source files/directories to include from local
master
Steps
1. Fetch upstream and create branch
git fetch upstream
git checkout -b feature/<feature> upstream/master2. Cherry-pick feature files from local master
git checkout master -- <files>Typically includes:
src/handlers/<feature>.ts— packet handlersrc/ui/<feature>/— UI component directorysrc/types/changes — if new event types were addedsrc/managers/<feature>.ts— if new manager functions were addedsrc/render/<feature>.ts— if new render classes were added
3. Manually patch shared integration files
These files aggregate feature code and can't be cleanly cherry-picked. Edit each one to add only the lines needed for this feature:
| File | What to add |
|---|---|
src/handlers/index.ts | Import and register call for the new handler |
src/main.ts | Import, instantiation, and wiring call for new UI components |
src/wiring/client-events.ts | Interface entry and event listeners for the new dialog |
src/wiring/ui-events.ts | Interface entry and event listeners (if dialog emits back to client) |
index.html | HTML template for new dialogs |
4. Verify the branch compiles and lints cleanly
npx tsc --noEmit
npx @biomejs/biome check --write .Fix any type errors — the branch must be standalone with no dependencies on other feature branches.
5. Commit and push
git add -A
git commit -m "feat: <description>"
git push origin feature/<feature>6. Create PR
Create a PR targeting sorokya/eoweb:master using gh pr create.
Important
- Each feature branch must be standalone — no dependencies on other feature PRs
- Only include code relevant to this specific feature
- The branch is based on
upstream/master, not localmaster