Code Review Analysis

# Code Review Analysis

## Table of Contents

- [Overview](#overview)
- [When to Use](#when-to-use)
- [Quick Start](#quick-start)
- [Reference Guides](#reference-guides)
- [Best Practices](#best-practices)

## Overview

Systematic code review process covering code quality, security, performance, maintainability, and best practices following industry standards.

## When to Use

- Reviewing pull requests and merge requests
- Analyzing code quality before merging
- Identifying security vulnerabilities
- Providing constructive feedback to developers
- Ensuring coding standards compliance
- Mentoring through code review

## Quick Start

Minimal working example:

```bash
# Check the changes
git diff main...feature-branch

# Review file changes
git diff --stat main...feature-branch

# Check commit history
git log main...feature-branch --oneline
```

## Reference Guides

Detailed implementations in the `references/` directory:

| Guide | Contents |
|---|---|
| [Initial Assessment](references/initial-assessment.md) | Initial Assessment |
| [Code Quality Analysis](references/code-quality-analysis.md) | Code Quality Analysis |
| [Security Review](references/security-review.md) | Security Review |
| [Performance Review](references/performance-review.md) | Performance Review |
| [Testing Review](references/testing-review.md) | Testing Review |
| [Best Practices](references/best-practices.md) | Best Practices |

## Best Practices

### ✅ DO

- Be constructive and respectful
- Explain the "why" behind suggestions
- Provide code examples
- Ask questions if unclear
- Acknowledge good practices
- Focus on important issues
- Consider the context
- Offer to pair program on complex issues

### ❌ DON'T

- Be overly critical or personal
- Nitpick minor style issues (use automated tools)
- Block on subjective preferences
- Review too many changes at once (>400 lines)
- Forget to check tests
- Ignore security implications
- Rush the review


#!/bin/bash
# validate-schema.sh - Validate database schema
# Usage: ./validate-schema.sh <schema_file>

set -euo pipefail

SCHEMA_FILE="${{1:?Usage: $0 <schema_file>}}"

echo "Validating schema: $SCHEMA_FILE"

# TODO: Add schema validation
# - Check SQL syntax
# - Verify foreign key references
# - Check index definitions
# - Validate naming conventions
# - Check for missing constraints

echo "Schema validation complete."


-- Migration: [description]
-- Created: [date]

-- TODO: Customize for your migration framework

BEGIN;

-- Up migration
-- TODO: Add schema changes
-- CREATE TABLE IF NOT EXISTS ...
-- ALTER TABLE ...

-- Down migration (rollback)
-- TODO: Add rollback statements
-- DROP TABLE IF EXISTS ...

COMMIT;


# Code Quality Analysis

## Code Quality Analysis

### Readability

```python
# ❌ Poor readability
def p(u,o):
    return u['t']*o['q'] if u['s']=='a' else 0

# ✅ Good readability
def calculate_order_total(user: User, order: Order) -> float:
    """Calculate order total with user-specific pricing."""
    if user.status == 'active':
        return user.tier_price * order.quantity
    return 0
```

### Complexity

```javascript
// ❌ High cognitive complexity
function processData(data) {
  if (data) {
    if (data.type === "user") {
      if (data.status === "active") {
        if (data.permissions && data.permissions.length > 0) {
          // deeply nested logic
        }
      }
    }
  }
}

// ✅ Reduced complexity with early returns
function processData(data) {
  if (!data) return null;
  if (data.type !== "user") return null;
  if (data.status !== "active") return null;
  if (!data.permissions?.length) return null;

  // main logic at top level
}
```


# Security Review

## Security Review

### Common